Add metric to expose cluster role count#47731
Merged
rosstimothy merged 3 commits intomasterfrom Oct 22, 2024
Merged
Conversation
817e1a8 to
30af33d
Compare
strideynet
reviewed
Oct 21, 2024
fspmarshall
reviewed
Oct 21, 2024
A new `teleport_roles_total` is added to count the number of roles in the cluster. The metric is intentionally updated infrequently to avoid putting any additional strain on the backend. Additionally, the reads performed when calculating the metric are rate limited to prevent any bursts in reads when the metric timer does fire. The auth periodic tickers have also been consolidated into a single multi-interval instead of a ticker per operation. To prevent the sub-intervals from impacting each other all operations are moved to their own goroutine once their ticker fires.
30af33d to
297e23a
Compare
fspmarshall
approved these changes
Oct 21, 2024
rosstimothy
added a commit
that referenced
this pull request
Oct 21, 2024
Add the new metric introduced in #47731 to the reference page. Also performed some minor formatting on the table, and alphabetized some out of order metrics.
strideynet
approved these changes
Oct 22, 2024
|
@rosstimothy See the table below for backport results.
|
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
Add the new metric introduced in #47731 to the reference page. Also performed some minor formatting on the table, and alphabetized some out of order metrics.
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
Add the new metric introduced in #47731 to the reference page. Also performed some minor formatting on the table, and alphabetized some out of order metrics.
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
Add the new metric introduced in #47731 to the reference page. Also performed some minor formatting on the table, and alphabetized some out of order metrics.
rosstimothy
added a commit
that referenced
this pull request
Oct 22, 2024
A new `teleport_roles_total` is added to count the number of roles in the cluster. The metric is intentionally updated infrequently to avoid putting any additional strain on the backend. Additionally, the reads performed when calculating the metric are rate limited to prevent any bursts in reads when the metric timer does fire. The auth periodic tickers have also been consolidated into a single multi-interval instead of a ticker per operation. To prevent the sub-intervals from impacting each other all operations are moved to their own goroutine once their ticker fires. * fix: specify a smallish page size
rosstimothy
added a commit
that referenced
this pull request
Oct 22, 2024
A new `teleport_roles_total` is added to count the number of roles in the cluster. The metric is intentionally updated infrequently to avoid putting any additional strain on the backend. Additionally, the reads performed when calculating the metric are rate limited to prevent any bursts in reads when the metric timer does fire. The auth periodic tickers have also been consolidated into a single multi-interval instead of a ticker per operation. To prevent the sub-intervals from impacting each other all operations are moved to their own goroutine once their ticker fires.
rosstimothy
added a commit
that referenced
this pull request
Oct 22, 2024
A new `teleport_roles_total` is added to count the number of roles in the cluster. The metric is intentionally updated infrequently to avoid putting any additional strain on the backend. Additionally, the reads performed when calculating the metric are rate limited to prevent any bursts in reads when the metric timer does fire. The auth periodic tickers have also been consolidated into a single multi-interval instead of a ticker per operation. To prevent the sub-intervals from impacting each other all operations are moved to their own goroutine once their ticker fires.
This was referenced Oct 22, 2024
rosstimothy
added a commit
that referenced
this pull request
Oct 22, 2024
A new `teleport_roles_total` is added to count the number of roles in the cluster. The metric is intentionally updated infrequently to avoid putting any additional strain on the backend. Additionally, the reads performed when calculating the metric are rate limited to prevent any bursts in reads when the metric timer does fire. The auth periodic tickers have also been consolidated into a single multi-interval instead of a ticker per operation. To prevent the sub-intervals from impacting each other all operations are moved to their own goroutine once their ticker fires.
rosstimothy
added a commit
that referenced
this pull request
Oct 22, 2024
A new `teleport_roles_total` is added to count the number of roles in the cluster. The metric is intentionally updated infrequently to avoid putting any additional strain on the backend. Additionally, the reads performed when calculating the metric are rate limited to prevent any bursts in reads when the metric timer does fire. The auth periodic tickers have also been consolidated into a single multi-interval instead of a ticker per operation. To prevent the sub-intervals from impacting each other all operations are moved to their own goroutine once their ticker fires.
rosstimothy
added a commit
that referenced
this pull request
Oct 22, 2024
A new `teleport_roles_total` is added to count the number of roles in the cluster. The metric is intentionally updated infrequently to avoid putting any additional strain on the backend. Additionally, the reads performed when calculating the metric are rate limited to prevent any bursts in reads when the metric timer does fire. The auth periodic tickers have also been consolidated into a single multi-interval instead of a ticker per operation. To prevent the sub-intervals from impacting each other all operations are moved to their own goroutine once their ticker fires.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
A new `teleport_roles_total` is added to count the number of roles in the cluster. The metric is intentionally updated infrequently to avoid putting any additional strain on the backend. Additionally, the reads performed when calculating the metric are rate limited to prevent any bursts in reads when the metric timer does fire. The auth periodic tickers have also been consolidated into a single multi-interval instead of a ticker per operation. To prevent the sub-intervals from impacting each other all operations are moved to their own goroutine once their ticker fires.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
A new `teleport_roles_total` is added to count the number of roles in the cluster. The metric is intentionally updated infrequently to avoid putting any additional strain on the backend. Additionally, the reads performed when calculating the metric are rate limited to prevent any bursts in reads when the metric timer does fire. The auth periodic tickers have also been consolidated into a single multi-interval instead of a ticker per operation. To prevent the sub-intervals from impacting each other all operations are moved to their own goroutine once their ticker fires.
rosstimothy
added a commit
that referenced
this pull request
Oct 31, 2024
#47731 consolidated the auth periodics to use a multi.Interval, however the upgrade window check called from the periodic launched it's own periodic, leading to a runaway number of upgrade window checks. This removes the extra periodic to reduce load upstream.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
#47731 consolidated the auth periodics to use a multi.Interval, however the upgrade window check called from the periodic launched it's own periodic, leading to a runaway number of upgrade window checks. This removes the extra periodic to reduce load upstream.
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
#47731 consolidated the auth periodics to use a multi.Interval, however the upgrade window check called from the periodic launched it's own periodic, leading to a runaway number of upgrade window checks. This removes the extra periodic to reduce load upstream.
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
#47731 consolidated the auth periodics to use a multi.Interval, however the upgrade window check called from the periodic launched it's own periodic, leading to a runaway number of upgrade window checks. This removes the extra periodic to reduce load upstream.
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
#47731 consolidated the auth periodics to use a multi.Interval, however the upgrade window check called from the periodic launched it's own periodic, leading to a runaway number of upgrade window checks. This removes the extra periodic to reduce load upstream.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
#47731 consolidated the auth periodics to use a multi.Interval, however the upgrade window check called from the periodic launched it's own periodic, leading to a runaway number of upgrade window checks. This removes the extra periodic to reduce load upstream.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
#47731 consolidated the auth periodics to use a multi.Interval, however the upgrade window check called from the periodic launched it's own periodic, leading to a runaway number of upgrade window checks. This removes the extra periodic to reduce load upstream.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
#47731 consolidated the auth periodics to use a multi.Interval, however the upgrade window check called from the periodic launched it's own periodic, leading to a runaway number of upgrade window checks. This removes the extra periodic to reduce load upstream.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
Add the new metric introduced in #47731 to the reference page. Also performed some minor formatting on the table, and alphabetized some out of order metrics.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
Add the new metric introduced in #47731 to the reference page. Also performed some minor formatting on the table, and alphabetized some out of order metrics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new
teleport_roles_totalis added to count the number of roles in the cluster. The metric is intentionally updated infrequently to avoid putting any additional strain on the backend. Additionally, the reads performed when calculating the metric are rate limited to prevent any bursts in reads when the metric timer does fire.The auth periodic tickers have also been consolidated into a single multi-interval instead of a ticker per operation. To prevent the sub-intervals from impacting each other all operations are moved to their own goroutine once their ticker fires.
changelog: Added a new
teleport_roles_totalmetric that exposes the number of roles which exist in a cluster